-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix logging cause by non-dropped table (#8955) #8961
Merged
ti-chi-bot
merged 3 commits into
pingcap:release-8.1
from
ti-chi-bot:cherry-pick-8955-to-release-8.1
Apr 18, 2024
Merged
ddl: Fix logging cause by non-dropped table (#8955) #8961
ti-chi-bot
merged 3 commits into
pingcap:release-8.1
from
ti-chi-bot:cherry-pick-8955-to-release-8.1
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-8.1
This PR is cherry-picked to release-8.1 from a source PR.
labels
Apr 18, 2024
12 tasks
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Apr 18, 2024
/run-all-tests |
JaySon-Huang
approved these changes
Apr 18, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Apr 18, 2024
JinheLin
approved these changes
Apr 18, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-8.1
This PR is cherry-picked to release-8.1 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8955
What problem does this PR solve?
Issue Number: close #8911
Problem Summary:
After #8910, if some tables are not able to be dropped,
SchemaSyncService::gcImpl
will run again with the same gc_safepoint.But in this path,
SchemaSyncService::gcImpl
always return true. So if there are some tables can not be dropped for some bugs, then this function will run again and again and print lots of loggings.What is changed and how it works?
if
succeeded == false
, then letSchemaSyncService::gcImpl
run again afterddl_sync_interval_seconds
Check List
Tests
Side effects
Documentation
Release note